Problem with javascript checking for missing attributes

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • lesliekirk
    Super Moderator











    • Aug 2008
    • 9291

    #1

    Problem with javascript checking for missing attributes

    Store is using a javascript function to popup an alert if an attribute has not been selected when the Add to Cart is clicked. When you click the "OK" to close the error message window, it adds the product to the cart without giving the shopper the opportunity to correct their oversight. I do not know if at some point in time it allowed for correction or it's always been this way. Not sure where to begin with this one.
    Leslie Kirk
    Miva Certified Developer
    Miva Merchant Specialist since 1997
    Previously of Webs Your Way
    (aka Leslie Nord leslienord)

    Email me: [email protected]
    www.lesliekirk.com

    Follow me: X | Facebook | Pinterest
  • Brennan
    Super Moderator









    • Jun 2009
    • 3481

    #2
    Is that native functionality of Miva or something custom built? If custom can you give us a URL as an example?
    Brennan Heyde
    VP Product
    Miva, Inc.
    [email protected]
    https://www.miva.com

    Comment

    • RTHOMASDESIGN
      Mivite








      • Jun 2015
      • 296

      #3
      Link? What ReadyTheme? Probably just need to move the error message out of the form, or modify the add-to-cart script (if it's not within the form).

      Comment

      • lesliekirk
        Super Moderator











        • Aug 2008
        • 9291

        #4
        Originally posted by RTHOMASDESIGN View Post
        Link? What ReadyTheme? Probably just need to move the error message out of the form, or modify the add-to-cart script (if it's not within the form).
        RTHOMASDESIGN and Brennan - it's custom, it's the Base ReadyTheme, it's here. The store owner said this just started happening.
        Leslie Kirk
        Miva Certified Developer
        Miva Merchant Specialist since 1997
        Previously of Webs Your Way
        (aka Leslie Nord leslienord)

        Email me: [email protected]
        www.lesliekirk.com

        Follow me: X | Facebook | Pinterest

        Comment

        • RTHOMASDESIGN
          Mivite








          • Jun 2015
          • 296

          #5
          Huh, someone must've changed something if it just started happening (or it never worked as intended). Search for "ValidateForm" within the CTGY page. IDK where the script is located exactly -- looks like it could be in the CTGY template. Anyway, the function "ValidateForm" should be updated.

          Considering the error messages it's definitely custom. The store owner should reach out to whoever created the script.

          -Ryan

          Comment

          • MGWben
            Mini Mivite

            • Jun 2019
            • 53

            #6
            Agreed with RTHOMASDESIGN , that validation check for the form looks custom and the way it's laid out would suggest it has always been like this. The form does its' error check for the attributes but it still is submitting to BASK regardless.

            That JS error check function could simply first prevent form submission, do the check, and then - if no error - submit the form as normal.
            Benjamin Smith - Developer
            www.midwestgunworks.com

            Comment

            • lesliekirk
              Super Moderator











              • Aug 2008
              • 9291

              #7
              Originally posted by RTHOMASDESIGN View Post
              Huh, someone must've changed something if it just started happening (or it never worked as intended). Search for "ValidateForm" within the CTGY page. IDK where the script is located exactly -- looks like it could be in the CTGY template. Anyway, the function "ValidateForm" should be updated.

              Considering the error messages it's definitely custom. The store owner should reach out to whoever created the script.

              -Ryan
              FYI - the script resides in the PROD Product Display Layout
              Leslie Kirk
              Miva Certified Developer
              Miva Merchant Specialist since 1997
              Previously of Webs Your Way
              (aka Leslie Nord leslienord)

              Email me: [email protected]
              www.lesliekirk.com

              Follow me: X | Facebook | Pinterest

              Comment

              • RTHOMASDESIGN
                Mivite








                • Jun 2015
                • 296

                #8
                Originally posted by lesliekirk View Post

                FYI - the script resides in the PROD Product Display Layout
                Ha, that's what I meant. Sorry! I've got CTGY on the brain (I've been working on several category templates lately).

                Comment

                • lesliekirk
                  Super Moderator











                  • Aug 2008
                  • 9291

                  #9
                  Originally posted by RTHOMASDESIGN View Post

                  Ha, that's what I meant. Sorry! I've got CTGY on the brain (I've been working on several category templates lately).
                  LOL, yeah, I know
                  Leslie Kirk
                  Miva Certified Developer
                  Miva Merchant Specialist since 1997
                  Previously of Webs Your Way
                  (aka Leslie Nord leslienord)

                  Email me: [email protected]
                  www.lesliekirk.com

                  Follow me: X | Facebook | Pinterest

                  Comment

                  Working...
                  X