Need a dev to implement these BASK template changes so that we can patch to 10.04

[Southlander]

https://github.com/mivaecommerce/readytheme-shadows/milestone/15?closed=1&_hsmi=214101494&_hsenc=p2ANqtz-9cCQ3kLqYtgslvOd2Sk6Wu-YA3RiUw27IOG1lwKIUbl11Xoyb7WimftQL6t9-ZTIo49RWTFYHTEFZzWn26CmvlD8R86g

Thank you,

[Southlander]

We use the Levels theme. The github shows the edits to the shadows theme. So there are some differences - not just copy and paste. I do not work with the page templates enough to feel comfortable doing the edits. Some are obvious and some are not to me.

Thanks,

[RTHOMASDESIGN]

Levels doesn't have the "basket undo" functionality built in the way that Shadows does -- so no template changes are needed there. You might still do a template search and replace (not sure if these entities are in use):

Search for:
&mvt:global:invalid_credentials;

Replace with:
&mvte:global:invalid_credentials;

https://github.com/mivaecommerce/readytheme-shadows/issues/129

-Ryan

[ids]

Hi Ryan,

Just confirming my conclusion is correct. Stores that have this UNDO capability in BASK need its template code updated? That actually makes the lines of code that are highlighted, with the Restore style variables, make sense.

Also want to make sure there is no other reasons.

Thanks,

Scott

[RTHOMASDESIGN]

As far as I'm aware... yes. I've only been working with the Shadows RT for the last couple years. That said, unless the store was built with Luxe, Colossus, or Shadows you shouldn't need to worry about the template update (as those are the only three themes to include the 'UNDO capability').

The recent updates seem to address unencoded entities/variables. I'm sure Miva will post additional updates if they're required for other themes... You just want to make sure that any entities used for inputs etc. are encoded (&mvte:).

Definitely do the search & replace as stated above – it applies to more themes than just Shadows.
-Ryan

[ids]

Thanks, Ryan. This answer reminded me I have a client's store using Colossus.

Scott

[Bruce - PhosphorMedia]

Levels doesn't have the "basket undo" functionality built in the way that Shadows does -- so no template changes are needed there. You might still do a template search and replace (not sure if these entities are in use):

Search for:
&mvt:global:invalid_credentials;

Replace with:
&mvte:global:invalid_credentials;

https://github.com/mivaecommerce/rea...ows/issues/129

-Ryan

One might also suggest doing a S&R for

value="&mvt:

and replace with

value="&mvte:

A couple of older sites we've done recently usually have a half dozen or more of these...and in general, input values should all be encoded.

[lesliekirk]

One might also suggest doing a S&R for

value="&mvt:

and replace with

value="&mvte:

A couple of older sites we've done recently usually have a half dozen or more of these...and in general, input values should all be encoded.

It's a great suggestion but what happens to any HTML/CSS that might be in the field(s) outputted by these entities?

[Bruce - PhosphorMedia]

Those are for inputs and the exact purpose of enconding them is to PREVENT people from entering html...like "script..."

[lesliekirk]

Levels doesn't have the "basket undo" functionality built in the way that Shadows does -- so no template changes are needed there. You might still do a template search and replace (not sure if these entities are in use):

Search for:
&mvt:global:invalid_credentials;

Replace with:
&mvte:global:invalid_credentials;

https://github.com/mivaecommerce/readytheme-shadows/issues/129

-Ryan

I'm working on a Levels site that DOES have the undo function. perhaps it was a custom addition? But anywho, I'm going to start a new post for it.

[RTHOMASDESIGN]

I'm working on a Levels site that DOES have the undo function. perhaps it was a custom addition? But anywho, I'm going to start a new post for it.

If you look at the template changes here:

https://www.miva.com/assets/template_changes_10.04.00.html

The primary difference is the encoding. The doc above should make it pretty easy to update any site that has the undo function :)
-Ryan

[lesliekirk]

If you look at the template changes here:

https://www.miva.com/assets/template_changes_10.04.00.html

The primary difference is the encoding. The doc above should make it pretty easy to update any site that has the undo function :)
-Ryan

FYI Matt shared this for a "bare bones" Levels https://gist.github.com/influxweb/75...d8c3ce7b6eec0a

[RTHOMASDESIGN]

FYI Matt shared this for a "bare bones" Levels https://gist.github.com/influxweb/75...d8c3ce7b6eec0a

Haha, well that should make it REALLY easy.
-Ryan