Miva Merchant 9.13.x Bug Reports

[Rick Wilson]

This thread is now closed, please update to 9.14.00 and post any 9.14.xx bugs here: https://www.miva.com/forums/forum/on...-x-bug-reports

[Bruce - PhosphorMedia]

If I FTP into the directory and delete the file and then upload the new one from the admin UI it works as expected. But that's what selecting the Overwrite option should do through the UI, I assume.

yes, it probably should, just making sure you had a work around.

[oliverands]

Not to negate the report, but...have you tried to manually upload and replace the file?

If I FTP into the directory and delete the file and then upload the new one from the admin UI it works as expected. But that's what selecting the Overwrite option should do through the UI, I assume.

[Bruce - PhosphorMedia]

I've just uncovered something odd that I think is a bug. (Could be a feature, but it doesn't fit my use case....)
...

Not to negate the report, but...have you tried to manually upload and replace the file?

[oliverands]

I've just uncovered something odd that I think is a bug. (Could be a feature, but it doesn't fit my use case....)

I have a digital product set up. Customers make purchases of that product. We discover something we want to correct in the digital product. I create a new version of the file. I go to the product in Miva and navigate to the Digital Download Settings tab. I´m serving the file locally, so I click on the button to upload the new version of the file. I select the file in the window that pops up and I make sure to click the "Overwrite" checkbox because I want to replace the file on the server with a new version of the file. The file uploads, a new Local File Path gets generated, and I click the Update button to save the changes. All good.

Now is when it gets weird. If I place a new order for that digital product, I will get a link that allows me to download the updated version of the file. But if a customer has already purchased the product and they use the download link in the order history or emailed sales receipt, they still download a copy of the old file. They don´t get a copy of the updated file.

For me, this isn´t optimal. If we find a problem with a digital product, we want to update it and make the revised version available to past purchasers of the product. I assumed this is what selecting the "Overwrite" option on upload would do--replace the version of the file on the server so all past and future downloads would receive the new, updated version.

[aubreyd]

When using the "New Order" function in the Admin panel, the system does not carry forward discounts associated with that customer (or prior order).

For example, we have a customer who is in one of our wholesale categories. The existing order shows their dealer pricing. "New Order" doesn't apply the associated discounts. They have to be added manually.

The only way to get the system to automatically apply them is to create a brand new order.

[habreu]

I think this may be a bug with the legacy price group interaction with non-legacy price groups. See https://www.miva.com/forums/forum/on...ultiple-groups if you create multiple price groups, and one of them is a Legacy price group you cannot have it excluded by the non-legacy groups -so either the legacy will work alone, or the non-legacy will. If you use 'Allow Combination' on the non-Legacy groups to allow the Legacy group it works but then you have the possibility of inadvertantly having products getting double discounting.

[Leanne]

Deferring execution gets complicated when there are a lot of moving parts all relying on one another. It's possible that magic-miva-imagemachine.js needs to be updated to support deferred functionality. You might just need to have someone who is familiar with deferred scripting look at your specific setup and see if it is actually doable with the plugins and scripts you're using. The scripts themselves may or may not need to be modified, deferred, etc. We made our scripts fairly easy to hook into, but if the outside scripts haven't been made to utilize that behavior, then the deferred stuff just won't work right.

Thanks, that's kind of what I was thinking. I did some work with some other deferred scripts over the weekend and quickly discovered how complex it can get to make them all still talk to each other in the order they require. I'll reach out to the Magic Zoom folks and see if they have any suggestions.

[rguisewite]

Unfortunately, that does not resolve the problem. When I defer Magic Zoom, I get this error:

ReferenceError: $J is not defined magic-miva-imagemachine.js:29:133

Deferring execution gets complicated when there are a lot of moving parts all relying on one another. It's possible that magic-miva-imagemachine.js needs to be updated to support deferred functionality. You might just need to have someone who is familiar with deferred scripting look at your specific setup and see if it is actually doable with the plugins and scripts you're using. The scripts themselves may or may not need to be modified, deferred, etc. We made our scripts fairly easy to hook into, but if the outside scripts haven't been made to utilize that behavior, then the deferred stuff just won't work right.

[rguisewite]

Hey Ryan - the "simple fix" didn't work in my case. I now have

clientside.mvc?T=959…ImageMachine.js:164 Uncaught TypeError: this.ImageMachine_Generate_Thumbnail is not a function at ImageMachine.Initialize (clientside.mvc?T=959…ImageMachine.js:164) at ImageMachine.oninitialize (clientside.mvc?T=959…=ImageMachine.js:93) at TM-SENSPE.html:685 

ImageMachine.Initialize
@
clientside.mvc?T=959…ImageMachine.js:164


ImageMachine.oninitialize
@
clientside.mvc?T=959…=ImageMachine.js:93


(anonymous)
@
TM-SENSPE.html:685

it looks like I need to add the code you have mentioned but where do I place it?

Probably the root level of whatever is calling the code failing in TM-SENSEPE.html on line 685. Since I can't actually see what's going on there... That's just a guess. Can you PM me a link to the page that's failing? I might have a better idea of what's going on and where things should go if I can see the bigger picture.

[lesliekirk]

Hey Nick,

The issue here is likely one of two things, possibly both (without knowing the full context of what you're doing/how you're doing it, it's not possible to know with 100% certainty, but the two things below are likely the culprit).

1. When you switched over to using async, that first code block (the one declaring var gallery) becomes wrapped in an anonymous function, taking any variable or function declared within that block out of the global context and placing it into the local context. As a result, anything attempting to access "gallery" outside of that block will no longer be able to access it. A simple fix for this is to just change "var gallery = [];" to "window.gallery = [];" and "gallery" becomes defined in the global context. This will 100% lead to the error you have above if left unchanged, because you're attempting to access gallery from prodscripts.min.js

2. If prodscripts.min.js is NOT loaded asynchronously and happens to be called before the block that sets up "gallery", even if #1 above is changed, you'll still run into JS issues, because that data won't have been created yet. The fix for that is to make sure whatever code is attempting to do stuff based on gallery is done AFTER the above block is run. This can be done the same way we do the above block, by wrapping it in an anonymous (or non-anonymous if it is inside a class) function and triggering it to be run based on the 'imagemachine_initialize' event being fired on the window. See below for an example:

(function( obj, eventType, fn )
{
if ( obj.addEventListener )
{
obj.addEventListener( eventType, fn, false );
}
else if ( obj.attachEvent )
{
obj.attachEvent( 'on' + eventType, fn );
}
})( window, 'imagemachine_initialize', function()
{
// Your code run from prodscripts.min.js attempting to do stuff based on "gallery" should be run here
});

Let me know if you have any problems with the above, or need further clarification.

Ryan

Hey Ryan - the "simple fix" didn't work in my case. I now have

clientside.mvc?T=959…ImageMachine.js:164 Uncaught TypeError: this.ImageMachine_Generate_Thumbnail is not a function at ImageMachine.Initialize (clientside.mvc?T=959…ImageMachine.js:164) at ImageMachine.oninitialize (clientside.mvc?T=959…=ImageMachine.js:93) at TM-SENSPE.html:685 

ImageMachine.Initialize
@
clientside.mvc?T=959…ImageMachine.js:164


ImageMachine.oninitialize
@
clientside.mvc?T=959…=ImageMachine.js:93


(anonymous)
@
TM-SENSPE.html:685

it looks like I need to add the code you have mentioned but where do I place it?

[Leanne]

It is likely that Magic Zoom is not being deferred ("ReferenceError: MivaEvents is not defined"), so it is attempting to access something that has yet to be loaded. The TypeError is probably a result of the MivaEvents failure. Try making Magic zoom deferred and see if that fixes the issue?

Unfortunately, that does not resolve the problem. When I defer Magic Zoom, I get this error:

ReferenceError: $J is not defined magic-miva-imagemachine.js:29:133

[lesliekirk]

Below is the js code the error is referencing in the console for the scripts file

Uncaught ReferenceError: gallery is not defined
at HTMLSpanElement.<anonymous> (prodscripts.js:284)

// ---- Open Product Image Gallery ---- //

productGallery: function (trigger) {

trigger.on('click', function (e) {

var startAt = Number($(this).attr('data-index'));



e.preventDefault();

if (gallery.length > 0) {X

$.magnificPopup.open({

callbacks: {

open: function () {

$.magnificPopup.instance.goTo(startAt);

}

},

gallery: {

enabled: true

},

items: gallery,

type: 'image'

});

}

else {

$.magnificPopup.open({

items: {

src: $('#js-main-image').attr('data-image')

},

type: 'image'

});

};

});

}



},

Did you by chance get this resolved? I've got the same problem.

[rguisewite]

Is anyone else using Magic Zoom with the current updates? I now have another problem where implementing the deferred js is breaking Magic Zoom. I am getting the following console errors:

ReferenceError: MivaEvents is not defined

TypeError: window[("image_data" + MMNum)] is undefined

It is likely that Magic Zoom is not being deferred ("ReferenceError: MivaEvents is not defined"), so it is attempting to access something that has yet to be loaded. The TypeError is probably a result of the MivaEvents failure. Try making Magic zoom deferred and see if that fixes the issue?

[Leanne]

Is anyone else using Magic Zoom with the current updates? I now have another problem where implementing the deferred js is breaking Magic Zoom. I am getting the following console errors:

ReferenceError: MivaEvents is not defined

TypeError: window[("image_data" + MMNum)] is undefined